Search for baselearner in this package #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search for
baselearnerin this package, not in the caller's namespace.When
baselearneris given as a string, it's limited (bymatch.arg) to the pre-defined choicesc("bbs", "bols", "btree", "bss", "bns"). It doesn't make sense to require the caller to import that symbol when we know it's defined in themboostpackage anyway.In my case, I'm invoking
mboostthrough a third-party package that does cross-validation, so it's impossible for me to importbtreeinto that namespace. The only solution is to do a shotgunlibrary(mboost)to export thebtreesymbol globally, but I'd like to avoid that.I also noticed that the
bnamevariable is never used, so I got rid of it.