Expect either boost::optional or std::optional from Boost.MPI#40
Open
aminiussi wants to merge 1 commit intoboostorg:developfrom
Open
Expect either boost::optional or std::optional from Boost.MPI#40aminiussi wants to merge 1 commit intoboostorg:developfrom
aminiussi wants to merge 1 commit intoboostorg:developfrom
Conversation
…mmes from boost::mpi API. For those optionals, access the values through optional::value (supported by both boost::optional and std::optional) instead of optional::get (nit supported by std::optional).
Contributor
|
This change looks fine but I'll have to fix whatever is wrong with the CI first, which I'm hoping it's just the Ubuntu 20.04 removal. |
Contributor
Hmm, no, it's something else, so this might take time to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 'fix' for #39.
It assume Boost MPI develop version boostorg/mpi@2eed4e7