Skip to content

Direct serialization #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 16, 2024
Merged

Direct serialization #956

merged 17 commits into from
Sep 16, 2024

Conversation

@grisumbras
Copy link
Member

@grisumbras grisumbras commented Nov 27, 2023

No description provided.

@cppalliance-bot
Copy link

cppalliance-bot commented Nov 27, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.89381% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.41%. Comparing base (72b0e8a) to head (8e1fc20).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/json/impl/serializer.hpp 97.70% 4 Missing ⚠️
include/boost/json/impl/serializer.ipp 99.36% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #956      +/-   ##
===========================================
+ Coverage    93.40%   93.41%   +0.01%     
===========================================
  Files           87       91       +4     
  Lines         8622     8672      +50     
===========================================
+ Hits          8053     8101      +48     
- Misses         569      571       +2
Files with missing lines Coverage Δ
include/boost/json/basic_parser.hpp 100.00% <ø> (ø)
include/boost/json/basic_parser_impl.hpp 98.50% <100.00%> (+0.14%) ⬆️
include/boost/json/detail/impl/stack.hpp 100.00% <100.00%> (ø)
include/boost/json/detail/impl/stack.ipp 100.00% <100.00%> (ø)
include/boost/json/detail/literals.hpp 100.00% <100.00%> (ø)
include/boost/json/detail/stack.hpp 100.00% <100.00%> (ø)
include/boost/json/impl/serialize.hpp 100.00% <100.00%> (ø)
include/boost/json/impl/serialize.ipp 95.60% <ø> (ø)
include/boost/json/serializer.hpp 100.00% <ø> (ø)
include/boost/json/impl/serializer.ipp 99.60% <99.36%> (-0.17%) ⬇️
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b0e8a...8e1fc20. Read the comment docs.

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 1, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 11, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 11, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 12, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 12, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 14, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 14, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 14, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 18, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 20, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 20, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@grisumbras grisumbras force-pushed the refactor/serializer branch 2 times, most recently from 6387c25 to ebb10f8 Compare December 21, 2023 08:42
@cppalliance-bot
Copy link

cppalliance-bot commented Dec 21, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 21, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 21, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 21, 2023

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Sep 10, 2024

An automated preview of the documentation is available at https://956.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

cppalliance-bot commented Sep 10, 2024

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

grisumbras and others added 16 commits September 16, 2024 18:15
@grisumbras
use helper for serialization implementation
a1ad262
@vinniefalco @grisumbras
stack can store nontrivial types
a7bdbcb
@grisumbras
detail::stack tests
cbab251
@grisumbras
refactor treatment of non-trivials by stack
0f48f98 
* trivial copyability is enough for fast approach;
* non-trivials are stored in a linked list interspersed with trivials;
* objects can be moved into stack
* non-trivial holders aren't polymorphic
@grisumbras
initial implementation of UDT serialization
b787cf1 
currently only arithmetic types are supported
@grisumbras
UDT serialization of bool and null
473aee9
@grisumbras
refactor fallback reset to null
532e21a
@grisumbras
UDT serialization of strings
bf39bc2
@grisumbras
UDT serialization of sequences
3caf6da
@grisumbras
UDT serialization of maps
d291537
@grisumbras
UDT serialization of tuples
5666575
@grisumbras
UDT serialization of described structs
42576b0
@grisumbras
UDT serialization of described enums
097a3da
@grisumbras
UDT serialization of variants
4a5e6bb
@grisumbras
UDT serialization of optionals
8f7b1ed
@grisumbras
UDT serialization of paths
7b493e7
@grisumbras grisumbras marked this pull request as ready for review September 16, 2024 15:15
@cppalliance-bot
Copy link

cppalliance-bot commented Sep 16, 2024

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

@cppalliance-bot
Copy link

cppalliance-bot commented Sep 16, 2024

An automated preview of the documentation is available at https://956.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@grisumbras grisumbras merged commit 8e1fc20 into boostorg:develop Sep 16, 2024
@grisumbras grisumbras deleted the refactor/serializer branch September 16, 2024 17:44
@cppalliance-bot
Copy link

cppalliance-bot commented Sep 16, 2024

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/956/pullrequest.html

This was referenced Oct 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grisumbras @cppalliance-bot @vinniefalco