feat: make image verifer plugins extensible#114
Merged
bcressey merged 1 commit intobottlerocket-os:developfrom Feb 24, 2026
Merged
feat: make image verifer plugins extensible#114bcressey merged 1 commit intobottlerocket-os:developfrom
bcressey merged 1 commit intobottlerocket-os:developfrom
Conversation
This was referenced Feb 2, 2026
ginglis13
approved these changes
Feb 11, 2026
Author
|
I've also verified that using this settings SDK, with no other changes to kits, still works for existing variants like |
ytsssun
reviewed
Feb 24, 2026
4b64868 to
a15929c
Compare
Author
|
Add fix from @ytsssun and test cases to confirm. |
Replace the hard-coded "notation" plugin with an extensible map. This allows additional plugins to be added by downstream builds, or at runtime by copying plugins to a host path. Plugins can store a corresponding trust policy in the settings API, which must be a base64-encoded JSON blob. Although this is optional, registering the trust policy with the OS ensures that it is measured into the TPM2 device, making it visible for remote attestation. The JSON format ensures that the policy can be canonicalized at runtime, rather than requiring it to be provied in canonical form. Signed-off-by: Ben Cressey <bcressey@amazon.com>
a15929c to
73e82b6
Compare
Contributor
|
Approved assuming CI passed. |
KCSesh
approved these changes
Feb 24, 2026
ytsssun
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related: bottlerocket-os/bottlerocket#4684
Description of changes:
Replace the hard-coded "notation" plugin with an extensible map. This allows additional plugins to be added by downstream builds, or at runtime by copying plugins to a host path.
Plugins can store a corresponding trust policy in the settings API, which must be a base64-encoded JSON blob. Although this is optional, registering the trust policy with the OS ensures that it is measured into the TPM2 device, making it visible for remote attestation. The JSON format ensures that the policy can be canonicalized at runtime, rather than requiring it to be provied in canonical form.
Testing done:
Verified that
enabledcan't be the name of a plugin:Verified that I can configure two other policies:
Terms of contribution:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.