Open
Conversation
Contributor
ArgoCD Diff Resultアプリケーション: n8n の差分パス: argoproj/n8n |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54a77e6d66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+176
to
+180
| kubectl exec -n n8n statefulset/postgres -- \ | ||
| pg_dump -U n8n -d n8n --clean --if-exists > n8n_backup_$(date +%Y%m%d).sql | ||
|
|
||
| # ローカルにコピー | ||
| kubectl cp n8n/postgres-0:/tmp/backup.sql ./n8n_backup.sql |
There was a problem hiding this comment.
kubectl exec ... pg_dump ... > n8n_backup_...sql の > はローカルシェルで解釈されるため、Pod 内の /tmp/backup.sql は作成されません。その直後に kubectl cp n8n/postgres-0:/tmp/backup.sql を実行するとファイル未存在で失敗し、記載どおりの運用手順ではバックアップ取得が完了できません。Pod 内に出力してから kubectl cp するか、最初にローカルへ出力したファイルをそのまま利用する手順に統一する必要があります。
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
n8n design doc and sample K8s manifests (External Secrets) for lolice cluster. Includes architecture, ESO data flow, security requirements, operational procedures, and sample YAMLs.