Crc && table needs update refactor #328
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fyi this is still a draft, because I want to test my cherry-picking session with a physical stream. |
- optional check function argument
|
Hello
I'll be happy that you spend time on it. So far for me it is pretty much a
mature project meaning I follow bug fixes.
I will definitely look into your PR
The kind of issues I left were some instability with unicast and the work
to get it in distributions. Some people report from time to time other
software getting a lock and not MuMuDVB, wonder if there has been some API
changes on the DVBAPI side
So in summary I'll look into your PRs, if you want I can make a new branch
so we mitigate the risks associated with refactoring.
Thank you !
Brice
…On Sun, Mar 23, 2025 at 6:22 PM Johannes ***@***.***> wrote:
Hey,
I would like to invest some work into this great project. When i tried to
orientate in the code-base, I made some small refactoring. Is this
interesting for you? Otherwise I am interested in points you would like to
see some work done to, Braice? If you find any time, feel free to leave a
comment.
Thank you for your time!
------------------------------
You can view, comment on, or merge this pull request online at:
#328
Commit Summary
- be7cd43
<be7cd43>
added calculateCRC32 fun
- a7f555b
<a7f555b>
general table_needs_update
- 0c22d39
<0c22d39>
pat use table_version
- 5b91802
<5b91802>
fixup! general table_needs_update
- 93a42b3
<93a42b3>
pat,pmt,sdt rewrite use calculateCRC32
- 69d9ecc
<69d9ecc>
docs & format
File Changes
(10 files <https://github.com/braice/MuMuDVB/pull/328/files>)
- *M* src/crc32.c
<https://github.com/braice/MuMuDVB/pull/328/files#diff-1695c44ad01fc6764630cf6ad63660c42d4ff00fa1a559f6295c7d6ff5d8ddfc>
(34)
- *A* src/crc32.h
<https://github.com/braice/MuMuDVB/pull/328/files#diff-cfc93ee0d8fd60f07f109eb8f90fdc23d4c31f9eda872b09f17cfb5b7a78ecb3>
(12)
- *M* src/mumudvb.c
<https://github.com/braice/MuMuDVB/pull/328/files#diff-82b2d700bfd4539dd6a4fbb54c8e6b8e4674b05753bc484d85e39fb71c59e3f8>
(3)
- *M* src/rewrite.c
<https://github.com/braice/MuMuDVB/pull/328/files#diff-fdcfffdd5794052e8043aaceff70c0eaccf2938ee7e5d9589ec1701027ca2472>
(30)
- *M* src/rewrite.h
<https://github.com/braice/MuMuDVB/pull/328/files#diff-b90b9f874389a95b6d27261278bba8326b13e8e3bea714027e5a006176c26baa>
(1)
- *M* src/rewrite_pat.c
<https://github.com/braice/MuMuDVB/pull/328/files#diff-63484b183faf93f365a938e20f92b1090e68d3979077a3d48d8e28d2489ab8d1>
(59)
- *M* src/rewrite_pmt.c
<https://github.com/braice/MuMuDVB/pull/328/files#diff-893b631107dcc272c31550315cfa14151f72c69cf5f0776f69be31b8fead6958>
(20)
- *M* src/rewrite_sdt.c
<https://github.com/braice/MuMuDVB/pull/328/files#diff-f114f14fed0fd4af14a563d95c494b5b3d91d441c433fc6c2174e3f6e1ee2b23>
(34)
- *M* src/ts.c
<https://github.com/braice/MuMuDVB/pull/328/files#diff-760caedaaf1c5d376354b2e1dba5e731a7c43017a97e93e81d18c78f3e61a4bf>
(4)
- *M* src/ts.h
<https://github.com/braice/MuMuDVB/pull/328/files#diff-e8362f0b97e78b88dcf0590e82e84838053ba49c90c9359b4613a0d29cfbd5e2>
(11)
Patch Links:
- https://github.com/braice/MuMuDVB/pull/328.patch
- https://github.com/braice/MuMuDVB/pull/328.diff
—
Reply to this email directly, view it on GitHub
<#328>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRID54HUSA5BVHH34DK5D2V3UXDAVCNFSM6AAAAABZTIAPCOVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2DCMZUGQYDENA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I would like to invest some work into this great project. When i tried to orientate in the code-base, I made some small refactoring. Is this interesting for you? Otherwise I am interested in points you would like to see some work done to, Braice? If you find any time, feel free to leave a comment.
Thank you for your time!