Update CHANGELOG.md and an argument for a parametrized constructor #123
Conversation
noguier
changed the title
browser-switch/src/main/java/com/braintreepayments/api/BrowserSwitchClient.java
Show resolved
Hide resolved
browser-switch/src/main/java/com/braintreepayments/api/BrowserSwitchClient.java
Show resolved
Hide resolved
tdchow
left a comment
tdchow
left a comment
There was a problem hiding this comment.
Changes look good! It looks like there are a lot of previous commits added in this PR. Would you be able to update the ana-dev branch with the latest commits from auth-tab-feature?
…ameter updated `CHANGELOG.md`
hey Tim, unnecessary commits should now be removed! |
saralvasquez
left a comment
saralvasquez
left a comment
There was a problem hiding this comment.
The rest of this looks great to me! Good job! 🎉
CHANGELOG.md
Outdated
| @@ -1,5 +1,14 @@ | |||
| # browser-switch-android Release Notes | |||
|
|
|||
| ## 3.1.1 | |||
There was a problem hiding this comment.
Should this be 3.1.1 or Unreleased? Not sure how it works for feature branches, but doesn't the release process automatically update to the correct release version?
There was a problem hiding this comment.
@tdchow you might know the answer to this a bit better
There was a problem hiding this comment.
Ah yeah that's a great catch. When we release the SDK, the release script will replace unreleased with the version number. So we'll need change the 3.3.1 to unreleased (lowercase unreleased - I think our script looks for that exact string).
There was a problem hiding this comment.
Great, thank you both for catching this. It is now addressed in 84cf245
Summary of changes
ActivityResultCalleras a parameterCHANGELOG.mdChecklist
Authors