Distinguish ~(deref a) from ~@a, don't unexpand reader macros if lossy#90
Open
frenchy64 wants to merge 1 commit intobrandonbloom:masterfrom
Open
Distinguish ~(deref a) from ~@a, don't unexpand reader macros if lossy#90frenchy64 wants to merge 1 commit intobrandonbloom:masterfrom
~(deref a) from ~@a, don't unexpand reader macros if lossy#90frenchy64 wants to merge 1 commit intobrandonbloom:masterfrom
Conversation
Use ~,@ as canonical form instead of ~ @ for emphasis.
850985f to
884c483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several problems unexpanding reader macros, sometimes yielding pretty-printings that don't round-trip.
~(deref foo)and~ @fooare being printed as~@foo.(var) => (var nil)(var 1 2 3) => (var 1)(let [deref a] (deref a)) => (let [deref a] @a)I try and fix all these issues in this PR.