Add quote_boundary opt to content_type/3#21
Closed
nallwhy wants to merge 2 commits intobreakroom:mainfrom
Closed
Conversation
Contributor
|
@nallwhy thanks! can I get a unit test for this? |
Contributor
Author
|
@tomtaylor Done! |
There was a problem hiding this comment.
Pull request overview
This PR adds a quote_boundary option to the content_type/3 function to support servers that don't accept quoted boundaries in Content-Type headers. By default, boundaries remain quoted to maintain backward compatibility.
Changes:
- Added optional
quote_boundaryparameter tocontent_type/3with a default value oftrue - Updated implementation to conditionally quote the boundary based on the option
- Added comprehensive test coverage for both quoted and unquoted boundary scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/multipart.ex | Added opts parameter to content_type/3 with quote_boundary option to control boundary quoting behavior |
| test/multipart_test.exs | Added test cases covering both default quoted boundary and explicit unquoted boundary behaviors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
Contributor
|
Thanks, I've superseded this in #23, but it will ship in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some servers don't accept quoted boundary.