Adds cross-tree drag and drop functionality.#306
Open
theearlofsandwich wants to merge 1 commit intobrimdata:mainfrom
Open
Adds cross-tree drag and drop functionality.#306theearlofsandwich wants to merge 1 commit intobrimdata:mainfrom
theearlofsandwich wants to merge 1 commit intobrimdata:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to drag and drop between multiple trees. It passes a reference to the drag tree on drop so you have access to what's being dropped. Works for both controlled and uncontrolled trees. I've updated the showcase demo pages to include a cross-tree demo and added some basic info into the readme.md.
There are some new tree properties, namely:
id?: string
allowCrossTreeDrop?: boolean;
allowCrossTreeDrag?: boolean;
and data handlers
onCrossTreeAdd?: handlers.CrossTreeAddHandler;
onCrossTreeDelete?: handlers.CrossTreeDeleteHandler;
I had to comment out the drop test code as drop now requires a reference to the initial drag tree.
Hope this code helps - it's probably not the most elegant but it does work and is reasonably comprehensive.