Skip to content

onClick w/o Drag new color not updated for call-back #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aschroederSportsdigita wants to merge 2 commits into
base: master
Choose a base branch
from
Open

onClick w/o Drag new color not updated for call-back #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36380cb
On single click w/o drag update color
Aug 17, 2017
fceea78
Reverting to original formatting
Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion js/bootstrap-colorpicker-module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ angular.module('colorpicker.module', [])
}
}

function mousemove(event) {
function setColor(event){
var
left = Slider.getLeftPosition(event),
top = Slider.getTopPosition(event),
Expand All @@ -442,10 +442,15 @@ angular.module('colorpicker.module', [])
if (withInput) {
pickerColorInput.val(newColor);
}
}

function mousemove(event) {
setColor(event);
return false;
}

function mouseup() {
setColor(event);
emitEvent('colorpicker-selected');
$document.off('mousemove', mousemove);
$document.off('mouseup', mouseup);
Expand Down
2 changes: 1 addition & 1 deletion js/bootstrap-colorpicker-module.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.