Validate MessageOneofRule

Makefile

@@ -17,7 +17,7 @@ ADD_LICENSE_HEADER := $(BIN)/license-header \
 		--copyright-holder "Buf Technologies, Inc." \
 		--year-range "2023-2025"
 # This version should be kept in sync with the version in buf.yaml
-PROTOVALIDATE_VERSION ?= v0.13.0
+PROTOVALIDATE_VERSION ?= v0.13.1
 # Version of the cel-spec that this implementation is conformant with
 # This should be kept in sync with the version in format_test.py
 CEL_SPEC_VERSION ?= v0.24.0

buf.yaml

@@ -2,8 +2,8 @@ version: v2
 modules:
   - path: proto
 deps:
-  - buf.build/bufbuild/protovalidate:v0.13.0
-  - buf.build/bufbuild/protovalidate-testing:v0.13.0
+  - buf.build/bufbuild/protovalidate:v0.13.1
+  - buf.build/bufbuild/protovalidate-testing:v0.13.1
 lint:
   use:
     - STANDARD

protovalidate/internal/rules.py

@@ -454,9 +454,18 @@ def add_oneof(
         rule: validate_pb2.MessageOneofRule,
     ):
         fields = []
+        seen = set()
+        if len(rule.fields) == 0:
+            msg = f"at least one field must be specified in oneof rule for the message {self._desc.full_name}"
+            raise CompilationError(msg)
+
         for name in rule.fields:
             if name in self._desc.fields_by_name:
+                if name in seen:
+                    msg = f"duplicate {name} in oneof rule for the message {self._desc.full_name}"
+                    raise CompilationError(msg)
                 fields.append(self._desc.fields_by_name[name])
+                seen.add(name)
             else:
                 msg = f'field "{name}" not found in message {self._desc.full_name}'
                 raise CompilationError(msg)