Fix instance check for concatenated values #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alfus
approved these changes
Aug 25, 2025
engnatha
reviewed
Aug 25, 2025
|
|
||
| def cel_unique(val: celtypes.Value) -> celpy.Result: | ||
| if not isinstance(val, celtypes.ListType): | ||
| if not isinstance(val, celtypes.ListType) and not isinstance(val, list): |
Contributor
There was a problem hiding this comment.
I think not isinstance(val, (celtypes.ListType, list)) would have worked here.
Member
Author
There was a problem hiding this comment.
ah, yeah, that's a little nicer. feel free to PR!
Contributor
There was a problem hiding this comment.
Happy to. #357 is up if you'd like to take a look.
engnatha
added a commit
to engnatha/protovalidate-python
that referenced
this pull request
Aug 25, 2025
The fix in bufbuild#354 had an extra `isinstance` call. The second argument can be a tuple of types, so this reduces it back down to one call.
stefanvanburen
pushed a commit
that referenced
this pull request
Aug 25, 2025
The fix in #354 used two `isinstance` calls. The second argument to `isinstance` allows for a tuple of types, so this PR reduces the check back down to 1 call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353.