Proposal: (buf.validate.message).oneof = { fields: ["field1", "field2"] } #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Collaborator
|
Huge +1, as this also solves oneofs for repeated and map fields (which cannot be used in a normal oneof) |
bufdev
force-pushed
the
message-oneof
branch
2 times, most recently
from
4ff479e to
2fe38ed
Compare
bufdev
changed the title
Member
|
Added in #377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal is pretty self-explanatory. Oneofs are awful to use in most languages, and have other annoying problems. Similar to
(buf.validate.field).required, provide a(buf.validate.message).oneofthat can be specified multiple times, and will have the property that only one field can returntrueforhas(also allowing it to be used for repeated fields). Should be pretty simple.