Merge JsonWriter & JsonStream #2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
previously approved these changes
Oct 15, 2025
bugsnag-android-core/src/main/java/com/bugsnag/android/JsonStream.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/JsonStream.kt
Outdated
Show resolved
Hide resolved
tomlongridge
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Reduce the class count and improve internal access to the
JsonStream.Design
Converted the previously package-protected
JsonWriterclass to Kotlin and merged it with theJsonStream(attribution and copyright notice forJsonWriterhave moved into theJsonStreamclass).Testing
Removed
JsonWriterspecific testing and otherwise relied on existing tests.