Skip to content

DELETE /widgets/{id} returnes 405" #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philsturgeon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DELETE /widgets/{id} returnes 405" #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e082971
test: added tests showing widget delete errs 405
philsturgeon Jun 27, 2025
14f633a
Apply suggestions from code review
philsturgeon Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions app/controllers/widgets_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,53 +2,54 @@ class WidgetsController < ApplicationController

# GET /widgets
def index
@widgets = Widget.all
widgets = Widget.all

if stale? @widgets
render json: @widgets
if stale? widgets
render json: widgets
end
end

# GET /widgets/:id
def show
@widget = Widget.find(params[:id])
widget = Widget.find(params[:id])

if stale? @widget
render json: @widget
if stale? widget
render json: widget
end
rescue ActiveRecord::RecordNotFound
render problem: { detail: 'The requested widget does not exist.' }, status: :not_found
end

# POST /widgets
def create
@widget = Widget.new(widget_params)
widget = Widget.new(widget_params)

if @widget.save
render location: @widget, status: :created
if widget.save
render location: widget, status: :created
else
render problem: { errors: @widget.errors }, status: :bad_request
render problem: { errors: widget.errors }, status: :bad_request
end
end

# PUT /widgets/:id
def update
@widget = Widget.find(params[:id])
widget = Widget.find(params[:id])

if @widget.update(widget_params)
render json: @widget
if widget.update(widget_params)
render json: widget
else
render problem: { errors: @widget.errors }, status: :bad_request
render problem: { errors: widget.errors }, status: :bad_request
end
rescue ActiveRecord::RecordNotFound
render problem: { detail: 'The requested widget does not exist.' }, status: :not_found
end

# DELETE /widgets/:id
def destroy
@widget = Widget.find(params[:id])
widget = Widget.find(params[:id])

@widget.destroy!
widget.destroy!
head :no_content
rescue ActiveRecord::RecordNotFound
render problem: { detail: 'The requested widget does not exist.' }, status: :not_found
end
Expand Down
19 changes: 19 additions & 0 deletions spec/requests/widgets_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,23 @@
expect(response).to match_openapi_doc(OPENAPI_DOC)
end
end

describe "DELETE /widgets/{id}" do
it 'responds with 204 for existing record' do
widget = create(:widget)

delete "/widgets/#{widget.id}"
expect(response).to have_http_status(:no_content)
expect(response).to match_openapi_doc(OPENAPI_DOC)

# Ensure the widget was deleted
expect(Widget.exists?(widget.id)).to be_falsey
end

it 'responds with 404 for non-existing record' do
delete '/widgets/' + SecureRandom.uuid_v7
expect(response).to have_http_status(:not_found)
expect(response).to match_openapi_doc(OPENAPI_DOC)
end
end
end
Loading