Fix two UAF errors in read_ihex_chunks() #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Linked list uses realloc but did not update the pointer in the previous linked list item resulting in Use-After-Free error. A backlink_p local variable is introduced to update the pointer address after a reallocation. 2. The local variable chunks_p was not updated after realloc which also resulted in UAF when allocating a new element to the linked list. A refreshing of the address was added after realloc.
Collaborator
|
Doh! Thanks. |
Author
|
No @gatk555, thank You! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked list uses realloc but did not update the pointer in the previous linked list item
resulting in Use-After-Free error. A backlink_p
local variable is introduced to update the pointer address after a reallocation.
The local variable chunks_p was not updated after realloc which also resulted in UAF when
allocating a new element to the linked list.
A refreshing of the address was added after realloc.