[feature][cp] feat: Add Spark to_json function#390
Merged
markjin1990 merged 2 commits intobytedance:mainfrom Mar 23, 2026
Merged
[feature][cp] feat: Add Spark to_json function#390markjin1990 merged 2 commits intobytedance:mainfrom
markjin1990 merged 2 commits intobytedance:mainfrom
Conversation
markjin1990
force-pushed
the
cherry-pick-spark-func-to-json
branch
from
9af9d0e to
26f39f0
Compare
frankobe
reviewed
Mar 13, 2026
| @@ -0,0 +1,82 @@ | |||
| /* | |||
markjin1990
force-pushed
the
cherry-pick-spark-func-to-json
branch
2 times, most recently
from
65a3c5d to
c3cb26c
Compare
Cherry-picked from facebookincubator/velox@a871a75 Original-author: Wechar Yu <yuwq1996@gmail.com> Cherry-picked-by: Zhongjun Jin <markjin1990@gmail.com> Original Commit Message: ------------------------------------------------------------ Summary: The `to_json` function converts a Json object (ROW, ARRAY or MAP) into a JSON string. Spark's implementation: https://github.com/apache/spark/blob/v3.5.1/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala#L672 https://docs.databricks.com/en/sql/language-manual/functions/to_json.html Pull Request resolved: #11995 Reviewed By: xiaoxmeng Differential Revision: D79266717 Pulled By: kKPulla fbshipit-source-id: da5308e663f1149dbfa5a95f6b61ee1c4ab86d7c ------------------------------------------------------------ Source: facebookincubator/velox@a871a75
markjin1990
force-pushed
the
cherry-pick-spark-func-to-json
branch
from
c3cb26c to
9ce2c7f
Compare
markjin1990
changed the title
frankobe
changed the title
Collaborator
|
Great work, I have some questions:
|
Collaborator
Author
|
@wangxinshuo-bolt Excellent questions! @frankobe also has the same concerns.
|
…cpp, 1) support varbinary type in Spark to_json, 2) fix Array with single empty ROW case in Spark to_json function.
markjin1990
commented
Mar 19, 2026
|
|
||
| auto input = makeRowVector({mapVector, arrayVector}); | ||
| auto expected = makeNullableFlatVector<std::string>( | ||
| {R"({"c0":{"blue":[1,2],"red":[null,4]},"c1":[{"blue":1,"red":2},{"green":null}]})", |
Collaborator
Author
There was a problem hiding this comment.
@wangxinshuo-bolt So far, the only difference between this cherry-picked Spark to_json function and the existing to_json is on the nested json object. Spark to_json function will add quotes around the nested keys, but existing to_json won't.
Collaborator
There was a problem hiding this comment.
@wangxinshuo-bolt So far, the only difference between this cherry-picked Spark to_json function and the existing to_json is on the nested json object. Spark to_json function will add quotes around the nested keys, but existing to_json won't.
I think "c0":{"blue":[1,2],"red":[null,4]} seems more reasonable, and we can use Spark to test the actual return value of the function.
Collaborator
Author
There was a problem hiding this comment.
@wangxinshuo-bolt Spark does have quotes around key strings.
Collaborator
There was a problem hiding this comment.
@wangxinshuo-bolt Spark does have quotes around key strings.
Excellent！
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #391
Type of Change
Description
to_jsonfacebookincubator/velox@a871a75ToJsonTest.longDecimalto be consistent with Spark which parses decimal '0.0000000000' as '0E-10' using scientific notation when Bolt supports Spark.Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes