Skip to content

[fix] fix unix_timestamp handles illegal input under legacy mode#415

Open
markjin1990 wants to merge 2 commits intobytedance:mainfrom
markjin1990:fix-unix-timestamp-illegal-input-oss
Open

[fix] fix unix_timestamp handles illegal input under legacy mode#415
markjin1990 wants to merge 2 commits intobytedance:mainfrom
markjin1990:fix-unix-timestamp-illegal-input-oss

Conversation

@markjin1990
Copy link
Collaborator

@markjin1990 markjin1990 commented Mar 20, 2026

What problem does this PR solve?

Issue Number: close #419

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Allow day, hour, minute, second to have one trailing 0, and extra whitespaces, under LEGACY mode, fully consistent with Spark.

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- Fix unix_timestamp to have behavior consistent with Spark under legacy mode given illegal input.

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@markjin1990 markjin1990 changed the title WIP: [fix] fix unix_timestamp handles illegal input under legacy mode [fix] fix unix_timestamp handles illegal input under legacy mode Mar 20, 2026
@markjin1990 markjin1990 force-pushed the fix-unix-timestamp-illegal-input-oss branch from 209b09c to 296b28e Compare March 20, 2026 08:51
@markjin1990 markjin1990 force-pushed the fix-unix-timestamp-illegal-input-oss branch from 029d765 to 557d830 Compare March 21, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] spark "unix_timestamp" behaves differently from spark on illegal data under legacy mode.

1 participant