Open
Conversation
Signed-off-by: Noah Cylich <noahcylich@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the vectorized exp/exp2 approximation used inside the FP16 attention softmax path back to the pre-“3n” polynomial form, aligning kernel_attention.cpp with the earlier implementation referenced in the PR description.
Changes:
- Replaced the higher-order fused-multiply-add polynomial for the fractional exponent with a 2nd-order Taylor approximation using
ln(2)andln(2)^2/2. - Applied the same change in both the Apple Accelerate-based attention path and the general NEON vectorized attention path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see there's no more diffs between this and the prior to 3n commit's kernel_attention.cpp:
d5cd5c0...d0ad24a