caddyhttp: Fix logging on wildcard sites when SkipUnmappedHosts is true #7372
+5
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://caddy.community/t/caddy-site-access-log-empty/33237, an edgecase bug when a wildcard site block is used alongside a catch-all block of the same listener. We weren't checking logger names with wildcards in
shouldLogRequestso it would fall through to thereturn !s.Logs.SkipUnmappedHostscase and prevent logging when it should have been logged.Repro config:
curl -v foo.localhost:8881should log, andcurl -v bar.localhost:8881should not log (because oflog_skip). Before, neither logged.Assistance Disclosure
None