fix bug in golang version argument #273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bullet-train.zsh-theme
Outdated
| if [[ (-f *.go(#qN) || -d Godeps || -f glide.yaml) ]]; then | ||
| if command -v go > /dev/null 2>&1; then | ||
| prompt_segment $BULLETTRAIN_GO_BG $BULLETTRAIN_GO_FG $BULLETTRAIN_GO_PREFIX" $(go version | grep --colour=never -oE '[[:digit:]].[[:digit:]]')" | ||
| prompt_segment $BULLETTRAIN_GO_BG $BULLETTRAIN_GO_FG $BULLETTRAIN_GO_PREFIX" $(go version |cut -d ' ' -f3 | cut -c '3-')" |
There was a problem hiding this comment.
We could get go version with only awk
go version | awk '{print substr($3, 3)}'
|
Thank you! It’s just quick and dirty one though.
…On Fri, Apr 6, 2018 at 20:53 Salmanul Farzy ***@***.***> wrote:
***@***.**** commented on this pull request.
Consider using awk instead of two cut commands.
------------------------------
In bullet-train.zsh-theme
<#273 (comment)>
:
> @@ -536,7 +535,7 @@ prompt_go() {
setopt extended_glob
if [[ (-f *.go(#qN) || -d Godeps || -f glide.yaml) ]]; then
if command -v go > /dev/null 2>&1; then
- prompt_segment $BULLETTRAIN_GO_BG $BULLETTRAIN_GO_FG $BULLETTRAIN_GO_PREFIX" $(go version | grep --colour=never -oE '[[:digit:]].[[:digit:]]')"
+ prompt_segment $BULLETTRAIN_GO_BG $BULLETTRAIN_GO_FG $BULLETTRAIN_GO_PREFIX" $(go version |cut -d ' ' -f3 | cut -c '3-')"
We could get go version with only awk
go version | awk '{print substr($3, 3)}'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#273 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADo_ceVSJApifOeC1OaGSI_fPTZaLhcFks5tl1cdgaJpZM4TJawn>
.
|
change the code as caiogondim#273 (review) recommend
|
Duplicate with #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current version is 1.10.1 which will cause the new line in the matching pattern as shown below.
to fix this issue, changing to pure cut command in the request.