Skip to content

Conversation

hconrad
Copy link

@hconrad hconrad commented Apr 24, 2018

Hello there,

Pardon if this is not the correct way to approach this. Yup this might be my first PR. Love the bullet-train theme. Today I started learning about go and noticed that there is an issue with multi segmented versions on the prompt output. It would look

1.1
0.10

and have a lot of white space. I think this new regex will work as long as the version number comes first.

Let me know if you want to discuss it's just a suggestion and appears to work with at least the current go version information.

@hconrad
Copy link
Author

hconrad commented Apr 24, 2018 via email

@embano1
Copy link
Contributor

embano1 commented Apr 26, 2018

Hi,

I also submitted a PR until someone pointed me to another PR on this :)
#264

@hconrad
Copy link
Author

hconrad commented Apr 26, 2018

Indeed :) I shall abandon mine :)

@hconrad hconrad closed this Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants