Skip to content

use char based StringBuilder.Append #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

use char based StringBuilder.Append #4568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ private static string GetLoggerValue(MSBuildLogger logger)
if (!string.IsNullOrWhiteSpace(logger.Class))
{
argumentBuilder.Append(logger.Class);
argumentBuilder.Append(",");
argumentBuilder.Append(',');
argumentBuilder.Append(logger.Assembly);
}
else
Expand All @@ -269,7 +269,7 @@ private static string GetLoggerValue(MSBuildLogger logger)

if (!string.IsNullOrWhiteSpace(logger.Parameters))
{
argumentBuilder.Append(";");
argumentBuilder.Append(';');
argumentBuilder.Append(logger.Parameters);
}

Expand Down
4 changes: 2 additions & 2 deletions src/Cake.Common/Tools/MSBuild/MSBuildRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,14 +291,14 @@ private static string GetLoggerArgument(MSBuildLogger logger)
if (!string.IsNullOrWhiteSpace(logger.Class))
{
argumentBuilder.Append(logger.Class);
argumentBuilder.Append(",");
argumentBuilder.Append(',');
}

argumentBuilder.Append(logger.Assembly.Quote());

if (!string.IsNullOrWhiteSpace(logger.Parameters))
{
argumentBuilder.Append(";");
argumentBuilder.Append(';');
argumentBuilder.Append(logger.Parameters);
}
return argumentBuilder.ToString();
Expand Down
4 changes: 2 additions & 2 deletions src/Cake.Core/Extensions/MethodInfoExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public static string GetSignature(this MethodInfo method,

var builder = new StringBuilder();
builder.Append(includeMethodNamespace ? method.GetFullName() : method.Name);
builder.Append("(");
builder.Append('(');
var parameters = method.GetParameters();
var parameterList = new string[parameters.Length];
for (var i = 0; i < parameterList.Length; i++)
Expand All @@ -42,7 +42,7 @@ public static string GetSignature(this MethodInfo method,
parameterList[i] = signature;
}
builder.Append(string.Join(", ", parameterList));
builder.Append(")");
builder.Append(')');
return builder.ToString();
}

Expand Down
6 changes: 3 additions & 3 deletions src/Cake.Core/Extensions/TypeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ private static string GetGenericTypeName(this Type type, bool includeNamespace)
if (includeNamespace)
{
builder.Append(type.Namespace);
builder.Append(".");
builder.Append('.');
}
builder.Append(type.Name.Substring(0, type.Name.IndexOf('`')));
builder.Append("<");
builder.Append('<');
builder.Append(GetGenericTypeArguments(type, includeNamespace));
builder.Append(">");
builder.Append('>');
return builder.ToString();
}

Expand Down
Loading