fix(dimensions): use getBoundingClientRect() instead of clientHeight#59
Open
sebelga wants to merge 1 commit intocallmecavs:masterfrom
Open
fix(dimensions): use getBoundingClientRect() instead of clientHeight#59sebelga wants to merge 1 commit intocallmecavs:masterfrom
sebelga wants to merge 1 commit intocallmecavs:masterfrom
Conversation
…ight element.clientHeight returns a rounded value for the element height and does not render the layout correctly when looking for the target column (columnTarget).
Author
|
Hi @callmecavs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves a small layout bug when instantiating the bricks.
If the bricks have a dom height with decimal value (e.g.
512.35),element.clientHeightreturns a rounded value for the element height and does not render the layout correctly when looking for the target column (columnTarget).So if we have 5 bricks all with an height of
512.35px, and a lyout with 4 columns, thecolumnHeightsmight look like[512, 513, 512, 513, 512]and the 5th element would be aligned at the 4th column instead of the 1st one.