fix: prevent elevation animation for contained Card mode #4681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the elevation animation issue for contained Card mode by preventing any elevation animation when the Card is in contained mode.
- Early exit added in the elevation animation function for contained mode
- Prevents unintended elevation animation when elevated value should be 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes an error that occurs when trying to animate elevation on a Card component in "contained" mode when pressing Card in contained mode, by preventing elevation animation, in contained mode, where elevation is always 0.
Related issue
Fixes: #4673
Fixes: #4617
Test plan
Tested in the rn template app, on the latest rn: