Skip to content

Add elevation prop to Modal component #4804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add elevation prop to Modal component #4804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
import { useSafeAreaInsets } from 'react-native-safe-area-context';
import useLatestCallback from 'use-latest-callback';

import Surface from './Surface';
import Surface, { Props as SurfaceProps } from './Surface';
import { useInternalTheme } from '../core/theming';
import type { ThemeProp } from '../types';
import { addEventListener } from '../utils/addEventListener';
Expand Down Expand Up @@ -53,6 +53,10 @@ export type Props = {
* Use this prop to change the default wrapper style or to override safe area insets with marginTop and marginBottom.
*/
style?: StyleProp<ViewStyle>;
/**
* Surface elevation
*/
elevation?: SurfaceProps['elevation'];
/**
* @optional
*/
Expand Down Expand Up @@ -109,6 +113,7 @@ function Modal({
children,
contentContainerStyle,
style,
elevation,
theme: themeOverrides,
testID = 'modal',
}: Props) {
Expand Down Expand Up @@ -220,6 +225,7 @@ function Modal({
testID={`${testID}-surface`}
theme={theme}
style={[{ opacity }, styles.content, contentContainerStyle]}
elevation={elevation}
container
>
{children}
Expand Down