Skip to content

FUSETOOLS2-2489: Migrate deployment of single file from Camel K to Debug adapter #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

FUSETOOLS2-2489: Migrate deployment of single file from Camel K to Debug adapter #745

merged 2 commits into from
Oct 28, 2024

Conversation

@djelinek
Copy link
Member

@djelinek djelinek commented Oct 9, 2024 •
edited
Loading

image

image

image

TODO

  • add unit tests --> too complicated, will be skipped in favor of ui tests
  • add ui tests --> DONE
  • documentation --> DONE

apupier
apupier reviewed Oct 9, 2024
View reviewed changes
apupier
apupier reviewed Oct 9, 2024
View reviewed changes
@djelinek djelinek force-pushed the fusetools2-2489 branch 14 times, most recently from b3c08aa to b1de33e Compare October 17, 2024 20:45
@djelinek djelinek requested a review from apupier October 17, 2024 20:53
apupier
apupier requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add a note in changelog
  • update readme/doc with this new feature and explaining scope (OpenShift, version required, Kubernetes config change)

@apupier
Copy link
Member

apupier commented Oct 18, 2024

I think the failing tests are due to the change in the UI and that the preference are shifted a bit in the Ui and so not everything is visible.
Camel User Settings Update Extra Launch Parameter setting Should add another parameter

@djelinek djelinek force-pushed the fusetools2-2489 branch 11 times, most recently from 984a86c to ab8fabd Compare October 23, 2024 13:22
@djelinek djelinek force-pushed the fusetools2-2489 branch 3 times, most recently from ae14f5b to d23172c Compare October 23, 2024 14:29
djelinek
djelinek commented Oct 23, 2024
View reviewed changes
djelinek
djelinek commented Oct 23, 2024
View reviewed changes
@djelinek
Copy link
Member Author

djelinek commented Oct 23, 2024

I think the failing tests are due to the change in the UI and that the preference are shifted a bit in the Ui and so not everything is visible. Camel User Settings Update Extra Launch Parameter setting Should add another parameter

fixed

@djelinek
Copy link
Member Author

djelinek commented Oct 23, 2024

  • add a note in changelog
  • update readme/doc with this new feature and explaining scope (OpenShift, version required, Kubernetes config change)

@apupier I have added doc page for kubernetes and also mentions in readme and changelog

@djelinek djelinek requested a review from apupier October 23, 2024 14:40
@apupier
Copy link
Member

apupier commented Oct 24, 2024

requires rebase on main branch to have all jobs in success

@djelinek djelinek marked this pull request as ready for review October 24, 2024 08:36
@djelinek
Copy link
Member Author

djelinek commented Oct 24, 2024 •
edited
Loading

requires rebase on main branch to have all jobs in success

I am not sure what you mean, I think it should be rebased on top of main branch already. I expect it is due to missing cyclonedx bump to latest version (but it was done for LSp repository not in DAP yet)

I will fix in another PR 🙂

@apupier
Copy link
Member

apupier commented Oct 24, 2024

requires rebase on main branch to have all jobs in success

I am not sure what you mean, I think it should be rebased on top of main branch already. I expect it is due to missing cyclonedx bump to latest version (but it was done for LSp repository not in DAP yet)

oops weird, i thought it was due to the eslint 9 upgrade bu tthe PR is not merged #748

@djelinek
Copy link
Member Author

djelinek commented Oct 24, 2024

requires rebase on main branch to have all jobs in success

I am not sure what you mean, I think it should be rebased on top of main branch already. I expect it is due to missing cyclonedx bump to latest version (but it was done for LSp repository not in DAP yet)

oops weird, i thought it was due to the eslint 9 upgrade bu tthe PR is not merged #748

aaahh you are right.. it contains also cyclonedx bump.. so I am going to merge it and after it will be just fine! thanks

@djelinek
Copy link
Member Author

djelinek commented Oct 24, 2024

btw hopefully today afternoon there should be done release of Camel 4.8.1.. so probably worthy to wait for it

djelinek
djelinek commented Oct 25, 2024
View reviewed changes
apupier
apupier approved these changes Oct 25, 2024
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@apupier apupier merged commit 2f4054d into camel-tooling:main Oct 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apupier apupier apupier approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djelinek @apupier