Merged
Conversation
Use io.TeeReader to capture the original file content during the first read instead of opening and reading the file a second time. This follows the same pattern already used for stdin diffing. Remove the now-unused readFile function. The previous code re-opened the file via openFile for the diff, but in practice the reader was already exhausted, producing incorrect diffs. TeeReader captures the actual content that was processed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
io.TeeReaderto capture original file content during the first read, instead of re-opening and reading the file a second time viareadFilereadFilefunctionopenFilefunction, but in test scenarios the reader was already exhausted, producing incorrect diffs (diffing empty string vs output instead of original vs output)Test plan
go build ./...passesgo vet ./...passesgo test -run 'TestEmbedStreams|TestEmbedFiles' ./...passes🤖 Generated with Claude Code