Skip to content

Conversation

@mckees
Copy link
Contributor

@mckees mckees commented Jul 17, 2025

Description

This provider contains tests for the graphics stack. Testing currently checks Vulkan by running Khronos's VK-GL-CTS, a conformance test suite. These checks ensure that our graphics stacks are conforming to Khronos's expected functionality for Vulkan.

Resolved issues

N/A

Documentation

See README

Tests

Tests have been run on Tiger Lake, Alder Lake, and Raptor Lake

@mckees mckees changed the title Add checkbox-gfx Vulkan tests Add checkbox-gfx Vulkan tests (New) Jul 17, 2025
Copy link
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for taking so long.
I've left some comments in the review, please ping me if you need further explanation.

@mckees mckees force-pushed the checkbox-gfx-vulkan branch from 606dc31 to 2b37f4e Compare July 30, 2025 03:24
@mckees mckees requested a review from fernando79513 July 30, 2025 06:20
Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

Copy link
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for the changes!

I've added a few more comments. I'll discuss with Max tomorrow about how to handle the Vulkan build, and I think we can merge this soon.

Copy link
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked with Max, and it should be okay building Vulkan and adding it as an artifact of the gh workflows as long as we don't do this too often.

I've just added a few more comments, but I think this should be good to land after that

@mckees mckees force-pushed the checkbox-gfx-vulkan branch from 54d3fe4 to f7f3579 Compare August 7, 2025 03:26
@mckees mckees force-pushed the checkbox-gfx-vulkan branch from f7f3579 to d28f8b3 Compare August 7, 2025 03:30
@mckees
Copy link
Contributor Author

mckees commented Aug 7, 2025

I've consolidated the CI scripts into one and left room to add the others in later (hence the matrix for a single value of "vulkan". To get an idea of how this will look with all scripts being tested (and seeing the run passing), see this PR: canonical/checkbox-gfx#18

@mckees mckees requested a review from fernando79513 August 7, 2025 16:31
@mckees mckees force-pushed the checkbox-gfx-vulkan branch from 74f482a to f5f2b39 Compare August 13, 2025 16:01
Copy link
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1!

@fernando79513 fernando79513 merged commit 423eb55 into canonical:main Aug 13, 2025
10 checks passed
bladernr pushed a commit that referenced this pull request Aug 28, 2025
* Add checkbox-gfx Vulkan tests

* Fix formatting issue found by Black

* Move Vulkan tests into Python and use sibling tests

* Remove slave language

* Remove unneeded bootstraps

* Reformat python file with black

* Add testing and change name for vulkan CTS runner script

* Consolidate CI scripts into one

* Add paths to Python runner to clean up sibling job line length

* Update contrib/checkbox-gfx/bin/test-vulkan

Co-authored-by: Fernando Bravo <[email protected]>

---------

Co-authored-by: Fernando Bravo <[email protected]>
stanley31huang pushed a commit that referenced this pull request Oct 3, 2025
* Add checkbox-gfx Vulkan tests

* Fix formatting issue found by Black

* Move Vulkan tests into Python and use sibling tests

* Remove slave language

* Remove unneeded bootstraps

* Reformat python file with black

* Add testing and change name for vulkan CTS runner script

* Consolidate CI scripts into one

* Add paths to Python runner to clean up sibling job line length

* Update contrib/checkbox-gfx/bin/test-vulkan

Co-authored-by: Fernando Bravo <[email protected]>

---------

Co-authored-by: Fernando Bravo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants