-
Couldn't load subscription status.
- Fork 67
Add checkbox-gfx Vulkan tests (New) #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and sorry for taking so long.
I've left some comments in the review, please ping me if you need further explanation.
contrib/checkbox-gfx/.github/workflows/build-vulkan-on-pr-arm.yaml
Outdated
Show resolved
Hide resolved
contrib/checkbox-gfx/checkbox-provider-gfx/units/vulkan/jobs.pxu
Outdated
Show resolved
Hide resolved
606dc31 to
2b37f4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment.
contrib/checkbox-gfx/.github/workflows/build-vulkan-on-pr-arm.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot for the changes!
I've added a few more comments. I'll discuss with Max tomorrow about how to handle the Vulkan build, and I think we can merge this soon.
contrib/checkbox-gfx/.github/workflows/build-vulkan-on-pr-arm.yaml
Outdated
Show resolved
Hide resolved
contrib/checkbox-gfx/.github/workflows/build-vulkan-on-pr-arm.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked with Max, and it should be okay building Vulkan and adding it as an artifact of the gh workflows as long as we don't do this too often.
I've just added a few more comments, but I think this should be good to land after that
contrib/checkbox-gfx/.github/workflows/build-vulkan-on-pr-arm.yaml
Outdated
Show resolved
Hide resolved
contrib/checkbox-gfx/checkbox-provider-gfx/units/vulkan/jobs.pxu
Outdated
Show resolved
Hide resolved
54d3fe4 to
f7f3579
Compare
f7f3579 to
d28f8b3
Compare
|
I've consolidated the CI scripts into one and left room to add the others in later (hence the matrix for a single value of "vulkan". To get an idea of how this will look with all scripts being tested (and seeing the run passing), see this PR: canonical/checkbox-gfx#18 |
Co-authored-by: Fernando Bravo <[email protected]>
74f482a to
f5f2b39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1!
* Add checkbox-gfx Vulkan tests * Fix formatting issue found by Black * Move Vulkan tests into Python and use sibling tests * Remove slave language * Remove unneeded bootstraps * Reformat python file with black * Add testing and change name for vulkan CTS runner script * Consolidate CI scripts into one * Add paths to Python runner to clean up sibling job line length * Update contrib/checkbox-gfx/bin/test-vulkan Co-authored-by: Fernando Bravo <[email protected]> --------- Co-authored-by: Fernando Bravo <[email protected]>
* Add checkbox-gfx Vulkan tests * Fix formatting issue found by Black * Move Vulkan tests into Python and use sibling tests * Remove slave language * Remove unneeded bootstraps * Reformat python file with black * Add testing and change name for vulkan CTS runner script * Consolidate CI scripts into one * Add paths to Python runner to clean up sibling job line length * Update contrib/checkbox-gfx/bin/test-vulkan Co-authored-by: Fernando Bravo <[email protected]> --------- Co-authored-by: Fernando Bravo <[email protected]>
Description
This provider contains tests for the graphics stack. Testing currently checks Vulkan by running Khronos's VK-GL-CTS, a conformance test suite. These checks ensure that our graphics stacks are conforming to Khronos's expected functionality for Vulkan.
Resolved issues
N/A
Documentation
See README
Tests
Tests have been run on Tiger Lake, Alder Lake, and Raptor Lake