Skip to content

Conversation

tomli380576
Copy link
Contributor

@tomli380576 tomli380576 commented Aug 22, 2025

Resolved issues

This PR updates the 1_gl_support_* cases from unity_support_test to glmark2 since the former has not been updated for almost 10 years. This new test uses almost exactly the same logic as reboot_check_test #1677 except that it just throws exceptions to fail early instead of trying to catch them.

Documentation

We are checking 2 things in this test:

  1. Is OpenGL version (from GL_VERSION) newer than 3.0? This requirement comes from gnome and GTK.
  2. Is the DUT using a hardware renderer? This part is the same as reboot_check_test.py -g except that it exits as soon as something goes wrong

A new cli option has been added:
--glmark2-override: manually select the glmark2 binary to run. Caller is responsible for checking whether this binary exists.

Tests

Unit tests
https://certification.canonical.com/hardware/202411-36032/submission/445444/

@tomli380576 tomli380576 marked this pull request as draft August 22, 2025 02:41
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 91.20879% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.09%. Comparing base (e3775c5) to head (ed1cfcf).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
providers/base/bin/gl_support.py 91.20% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
+ Coverage   52.01%   52.09%   +0.08%     
==========================================
  Files         388      388              
  Lines       41794    41886      +92     
  Branches     7771     7794      +23     
==========================================
+ Hits        21738    21822      +84     
  Misses      19282    19282              
- Partials      774      782       +8     
Flag Coverage Δ
provider-base 28.38% <91.20%> (+0.36%) ⬆️
provider-certification-client 57.14% <ø> (ø)
provider-certification-server 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomli380576 tomli380576 marked this pull request as ready for review August 22, 2025 07:40
@tomli380576 tomli380576 linked an issue Aug 26, 2025 that may be closed by this pull request
1 task
@tomli380576 tomli380576 marked this pull request as draft August 27, 2025 02:06
@tomli380576 tomli380576 marked this pull request as ready for review August 27, 2025 02:22
@tomli380576 tomli380576 marked this pull request as draft August 27, 2025 02:37
@tomli380576 tomli380576 marked this pull request as ready for review August 27, 2025 02:49
Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried with my project which is using mali GPU, and the change works perfectly.
https://certification.canonical.com/hardware/202507-36924/submission/451589/test-results/pass/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The *gl_support* test fails with NV driver installed under Wayland

3 participants