-
Notifications
You must be signed in to change notification settings - Fork 67
Update gl support test to use glmark2 (New) #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2087 +/- ##
==========================================
+ Coverage 52.01% 52.09% +0.08%
==========================================
Files 388 388
Lines 41794 41886 +92
Branches 7771 7794 +23
==========================================
+ Hits 21738 21822 +84
Misses 19282 19282
- Partials 774 782 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried with my project which is using mali GPU, and the change works perfectly.
https://certification.canonical.com/hardware/202507-36924/submission/451589/test-results/pass/
Resolved issues
This PR updates the
1_gl_support_*cases from unity_support_test to glmark2 since the former has not been updated for almost 10 years. This new test uses almost exactly the same logic asreboot_check_test#1677 except that it just throws exceptions to fail early instead of trying to catch them.Documentation
We are checking 2 things in this test:
reboot_check_test.py -gexcept that it exits as soon as something goes wrongA new cli option has been added:
--glmark2-override: manually select the glmark2 binary to run. Caller is responsible for checking whether this binary exists.Tests
Unit tests
https://certification.canonical.com/hardware/202411-36032/submission/445444/