wifi test: unify code behaviour between two tests (BugFix) #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartin013
suggested changes
Oct 16, 2025
|
|
||
| # Check connection by ping or link status | ||
| print_head("Perform a ping test") | ||
| perform_ping_test(args.interface, renderer) |
There was a problem hiding this comment.
From what I see here, we don't have a clear status when the test is successful: "Connection test passed\n" isn't printed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When working on #2116 I noticed the code behaviour was different between two wifi tests, one having a far more useful error message triggered through an exception.
I have thus updated the more basic one to use the same mechanism.
Resolved issues
Documentation
Tests