Skip to content

Conversation

@yanksyoon
Copy link
Member

Applicable spec:

This PR may be dropped, depending on implementation of multi-charm/application per VM deployment strategy. Perhaps we should look into making the application standalone, making use of XDG_ vars.

Overview

  • Introduce logging path configuration on the application level

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 277 files.

Valid Invalid Ignored Fixed
0 62 215 0
Click to see the invalid file list
  • .copilot-collections.yaml
  • .vale.ini
  • Makefile
  • Makefile.docs
  • actions.yaml
  • charmcraft.yaml
  • config.yaml
  • metadata.yaml
  • pyproject.toml
  • src/charm.py
  • src/charm_state.py
  • src/errors.py
  • src/factories.py
  • src/logrotate.py
  • src/manager_client.py
  • src/manager_service.py
  • src/models.py
  • src/utilities.py
  • terraform/charm/main.tf
  • terraform/charm/outputs.tf
  • terraform/charm/variables.tf
  • terraform/charm/versions.tf
  • terraform/product/main.tf
  • terraform/product/outputs.tf
  • terraform/product/variables.tf
  • terraform/product/version.tf
  • tests/init.py
  • tests/conftest.py
  • tests/integration/init.py
  • tests/integration/conftest.py
  • tests/integration/data/clouds.yaml.tmpl
  • tests/integration/helpers/init.py
  • tests/integration/helpers/charm_metrics.py
  • tests/integration/helpers/common.py
  • tests/integration/helpers/openstack.py
  • tests/integration/setup-integration-tests.sh
  • tests/integration/test_charm_fork_path_change.py
  • tests/integration/test_charm_fork_repo.py
  • tests/integration/test_charm_metrics_failure.py
  • tests/integration/test_charm_metrics_success.py
  • tests/integration/test_charm_no_runner.py
  • tests/integration/test_charm_runner.py
  • tests/integration/test_charm_upgrade.py
  • tests/integration/test_e2e.py
  • tests/integration/test_prometheus_metrics.py
  • tests/integration/test_reactive.py
  • tests/integration/utils_reactive.py
  • tests/status_name.py
  • tests/unit/init.py
  • tests/unit/conftest.py
  • tests/unit/factories.py
  • tests/unit/mock.py
  • tests/unit/test_charm.py
  • tests/unit/test_charm_state.py
  • tests/unit/test_factories.py
  • tests/unit/test_logrotate.py
  • tests/unit/test_manager_client.py
  • tests/unit/test_manager_service.py
  • tests/unit/test_manager_service_logging.py
  • tests/unit/test_utilities.py
  • tox.ini
  • trivy.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 277 files.

Valid Invalid Ignored Fixed
0 62 215 0
Click to see the invalid file list
  • .copilot-collections.yaml
  • .vale.ini
  • Makefile
  • Makefile.docs
  • actions.yaml
  • charmcraft.yaml
  • config.yaml
  • metadata.yaml
  • pyproject.toml
  • src/charm.py
  • src/charm_state.py
  • src/errors.py
  • src/factories.py
  • src/logrotate.py
  • src/manager_client.py
  • src/manager_service.py
  • src/models.py
  • src/utilities.py
  • terraform/charm/main.tf
  • terraform/charm/outputs.tf
  • terraform/charm/variables.tf
  • terraform/charm/versions.tf
  • terraform/product/main.tf
  • terraform/product/outputs.tf
  • terraform/product/variables.tf
  • terraform/product/version.tf
  • tests/init.py
  • tests/conftest.py
  • tests/integration/init.py
  • tests/integration/conftest.py
  • tests/integration/data/clouds.yaml.tmpl
  • tests/integration/helpers/init.py
  • tests/integration/helpers/charm_metrics.py
  • tests/integration/helpers/common.py
  • tests/integration/helpers/openstack.py
  • tests/integration/setup-integration-tests.sh
  • tests/integration/test_charm_fork_path_change.py
  • tests/integration/test_charm_fork_repo.py
  • tests/integration/test_charm_metrics_failure.py
  • tests/integration/test_charm_metrics_success.py
  • tests/integration/test_charm_no_runner.py
  • tests/integration/test_charm_runner.py
  • tests/integration/test_charm_upgrade.py
  • tests/integration/test_e2e.py
  • tests/integration/test_prometheus_metrics.py
  • tests/integration/test_reactive.py
  • tests/integration/utils_reactive.py
  • tests/status_name.py
  • tests/unit/init.py
  • tests/unit/conftest.py
  • tests/unit/factories.py
  • tests/unit/mock.py
  • tests/unit/test_charm.py
  • tests/unit/test_charm_state.py
  • tests/unit/test_factories.py
  • tests/unit/test_logrotate.py
  • tests/unit/test_manager_client.py
  • tests/unit/test_manager_service.py
  • tests/unit/test_manager_service_logging.py
  • tests/unit/test_utilities.py
  • tox.ini
  • trivy.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants