Remove ALLFILES from makefile
#434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnneCYH
reviewed
Oct 21, 2025
AnneCYH
previously requested changes
Oct 21, 2025
Contributor
AnneCYH
left a comment
AnneCYH
left a comment
There was a problem hiding this comment.
Hey @tarek-y-ismail , thanks for this!
Do take a look at the feedback and lemme know if there are any questions, thanks!
tarek-y-ismail
force-pushed
the
drop-unused-makefile-variables
branch
from
27f3d4b to
fe49710
Compare
tarek-y-ismail
requested review from
SecondSkoll,
akcano,
dwilding,
medubelko,
minaelee,
rkratky and
tang-mm
as code owners
tarek-y-ismail
force-pushed
the
drop-unused-makefile-variables
branch
from
fe49710 to
e2b214d
Compare
tarek-y-ismail
changed the title
CONFIRM_SUDO and ALLFILES from makefileALLFILES from makefile
SecondSkoll
approved these changes
Nov 5, 2025
SecondSkoll
added a commit
that referenced
this pull request
Nov 13, 2025
* fix: CLA check to run on PRs only * refactor: Replace build_metrics.sh with something nicer (#373) * Replace build_metrics.sh with something nicer * docs: update changelog * docs: fix info about setting RTD key as GitHub deploy key (#423) * fix: spelling mistake in update script (#425) * fix spelling mistake in update script * add change to CHANGELOG.md * Add warning to set-up-automated-testing.rst (#427) * feat: exclude generated pages from sitemap by default, document wildcards (#429) * add info about wildcard excludes * add placeholder sitemap_excludes in conf.py * adjust wording of comment * enable typical sitemap_excludes by default * use consistent wording and formatting * Use long parameter for 'fail on warning' (#430) * docs: add troubleshooting how-to (#432) Add tag desync as the first issue. * Fix stale references to `custom_conf.py` (#433) * fix(ci): make check-removed-urls work with private forks (#437) * fix(ci): make check-removed-urls work with private forks Fixes #436 * docs: update changelog * chore: add `CODEOWNERS` (#439) * chore: add `CODEOWNERS` Enumerate individual reviewers for now. Later, we can add a Sphinx development team, once we've established one. * docs: add #438 to changelog * chore: missing hyphen Co-authored-by: Michael Park <[email protected]> * chore: revert changelog entry Co-authored-by: Michael Park <[email protected]> --------- Co-authored-by: Michael Park <[email protected]> * Update Open Graph image URL in conf.py (#441) The preview image being used was an old one, and the design team has suggested the use of this one instead. * Update workflow action versions (#445) * update workflow action versions * update changelog * Update CHANGELOG.md Co-authored-by: Dave Wilding <[email protected]> --------- Co-authored-by: Dave Wilding <[email protected]> * Fix whitespace and executable flag of scripts (#448) * make scripts executable * remove whitespace from vale script * update CHANGELOG.md * docs: add how-to guide for Mermaid diagramming tool (#442) Signed-off-by: annecyh <[email protected]> * Move from canonical-sphinx-exensions to individual packages (#449) * Move from canonical-sphinx-exensions to individual packages * Update CHANGELOG.md * build(deps): bump sphinx-terminal to v0.1.1 (#454) * docs: add how-to guide for sphinx autodoc extension (#450) * docs: update how to index.rst add autodocs * docs: create autodocs.md * fix: conf file formatting in autodocs.md * fix: fix conf.py formatting in autodocs.md * fix: pr comment updates * fix: requested pr changes Signed-off-by: Ashley Cliff <[email protected]> * fix: autodoc table formatting Signed-off-by: Ashley Cliff <[email protected]> * docs: update changelog for autodoc Signed-off-by: Ashley Cliff <[email protected]> * fix: autodoc spell fix Signed-off-by: Ashley Cliff <[email protected]> * fix: autodoc formatting Signed-off-by: Ashley Cliff <[email protected]> --------- Signed-off-by: Ashley Cliff <[email protected]> * build: move Vale dependencies to requirements.txt (#456) * move Vale dependencies to requirements.txt * add PR link to CHANGELOG.md * Add OpenAPI how-to guide (#446) * Add OpenAPI how-to guide * Include RTD steps in OpenAPI how-to guide * docs: add guidelines for using custom base templates (#455) * docs: add guidelines for using custom base templates Signed-off-by: annecyh <[email protected]> * docs: add a how-to guide for data tables (#451) * add first draft of data tables guide * add data tables guide to index * add details about Sphinx DataTables * adjust wording * update landing page per suggestion * adjust wording * mention new doc in CHANGELOG * remove full stop * put links in alphabetical order * use reST formatting * explain purpose of links and remove duplicated links * improve wording per review * docs: consolidate custom template information (#459) Signed-off-by: annecyh <[email protected]> * Details about sphinx-terminal (#447) * Details about sphinx-terminal * Describe the terminal copy button Co-authored-by: JJ Coldiron <[email protected]> * fix(build): remove em dash from fallback target (#461) #388 introduced an emdash in the makefile that was almost certainly not intended; this causes the fallthrough case to infinitely recurse. --------- Signed-off-by: Wesley Hershberger <[email protected]> Co-authored-by: Michael DuBelko <[email protected]> * feat!: incorporate redesigned terminal (#460) * fix(docs): update style guide redirects (#453) * docs: add step to remove CODEOWNERS in the tutorial (#458) Reorganise the first two sections so copying and pruning files are discrete actions. * Ensure update_sp.py is executable from any directory not just docs/ (#424) * ensure this file is executable from any directory not just docs/ * Add a new line * update requirements.txt path * update NEWFILES.txt path * chore: refactor makefile (#426) Co-authored-by: Michael Park <[email protected]> * chore: Remove `ALLFILES` from makefile (#434) * Remove `ALLFILES` from Makefile * Update changelog --------- Co-authored-by: Michael Park <[email protected]> * feat: better canonical URL support (#462) * fix: config for canonical URL * docs: update html_baseurl context in conf file * Update CHANGELOG.md * Update CHANGELOG.md * chore: reword changelog entry * chore: bump version * fix: CHANGELOG * fix: spelling issues --------- Signed-off-by: annecyh <[email protected]> Signed-off-by: Ashley Cliff <[email protected]> Signed-off-by: Wesley Hershberger <[email protected]> Co-authored-by: Dave Jones <[email protected]> Co-authored-by: Dave Wilding <[email protected]> Co-authored-by: Erin Conley <[email protected]> Co-authored-by: Robert Krátký <[email protected]> Co-authored-by: Michael DuBelko <[email protected]> Co-authored-by: tarek-y-ismail <[email protected]> Co-authored-by: Alex Lowe <[email protected]> Co-authored-by: Dimple Kuriakose <[email protected]> Co-authored-by: AnneCYH <[email protected]> Co-authored-by: Artem Konev <[email protected]> Co-authored-by: JJ Coldiron <[email protected]> Co-authored-by: Ashley Cliff <[email protected]> Co-authored-by: Marek Suchánek <[email protected]> Co-authored-by: Wesley Hershberger <[email protected]> Co-authored-by: Michael DuBelko <[email protected]> Co-authored-by: Charles Uneze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdwith relevant non-documentation file changes?Noticed
those twothis one unused variables while looking at the makefile :)