Remove CONFIRM_SUDO and ALLFILES from makefile
#434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnneCYH
reviewed
Oct 21, 2025
| ALLFILES = *.rst **/*.rst | ||
| METRICSDIR = $(SOURCEDIR)/.sphinx/metrics | ||
| REQPDFPACKS = latexmk fonts-freefont-otf texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended texlive-font-utils texlive-lang-cjk texlive-xetex plantuml xindy tex-gyre dvipng | ||
| CONFIRM_SUDO ?= N |
There was a problem hiding this comment.
Hi @tarek-y-ismail , we do check the CONFIRM_SUDO variable in the GHA workflow:
We should keep it here.
But I think ALLFILES should safe to remove.
AnneCYH
requested changes
Oct 21, 2025
There was a problem hiding this comment.
Hey @tarek-y-ismail , thanks for this!
Do take a look at the feedback and lemme know if there are any questions, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdwith relevant non-documentation file changes?Noticed those two unused variables while looking at the makefile :)