Skip to content

Remove CONFIRM_SUDO and ALLFILES from makefile #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove CONFIRM_SUDO and ALLFILES from makefile #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a572ea
Remove `CONFIRM_SUDO` and `ALLFILES`
tarek-y-ismail Sep 5, 2025
27f3d4b
Update changelog
tarek-y-ismail Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Upcoming

* Changes metrics script to a less brittle Python script
* Dropped unused makefile variables `ALLFILES` and `CONFIRM_SUDO`

### Added

Expand Down
2 changes: 0 additions & 2 deletions docs/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ VENVDIR = $(SPHINXDIR)/venv
PA11Y = $(SPHINXDIR)/node_modules/pa11y/bin/pa11y.js --config $(SPHINXDIR)/pa11y.json
VENV = $(VENVDIR)/bin/activate
TARGET = *
ALLFILES = *.rst **/*.rst
METRICSDIR = $(SOURCEDIR)/.sphinx/metrics
REQPDFPACKS = latexmk fonts-freefont-otf texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended texlive-font-utils texlive-lang-cjk texlive-xetex plantuml xindy tex-gyre dvipng
CONFIRM_SUDO ?= N
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tarek-y-ismail , we do check the CONFIRM_SUDO variable in the GHA workflow:

sphinx-docs-starter-pack/.github/workflows/test-starter-pack.yml

Line 24 in f5a4b4a

run: make -C docs woke CONFIRM_SUDO=y

We should keep it here.
But I think ALLFILES should safe to remove.

VALE_CONFIG = $(SPHINXDIR)/vale.ini
SPHINX_HOST ?= 127.0.0.1
SPHINX_PORT ?= 8000
Expand Down
Loading