-
Couldn't load subscription status.
- Fork 66
Details about sphinx-terminal #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing linkcheck tests due to malformed URLs, see suggestions. Ty!
|
Requesting review from @jahn-junior also because he has been working on terminal extension updates recently, maybe there's something to be noted here. |
|
Thanks for doing this! I've found that a handful of the |
Co-authored-by: JJ Coldiron <[email protected]>
Co-authored-by: JJ Coldiron <[email protected]>
|
I think this should now be ready to merge. I've applied all suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marek!
In general, I think we need to flag all custom Canonical Sphinx directives as such (explicitly mentioning they are not a part of MyST or rST standard syntax), including any information about versions and options (such as the copy option), but this can be a part of the starter pack docs updates epic next cycle rather than holding up this PR.
Some useful options for the
sphinx-terminalextension were missing. I've added one (:dir:) and linked the upstream documentation for the rest.