Verification coldcard checkout#495
Open
KartikBansal4976 wants to merge 3 commits intocaravan-bitcoin:mainfrom
Open
Verification coldcard checkout#495KartikBansal4976 wants to merge 3 commits intocaravan-bitcoin:mainfrom
KartikBansal4976 wants to merge 3 commits intocaravan-bitcoin:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c102d2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Coldcard address verification flow and add config helper UI
Fixes #476
ISSUE
Coldcard address verification was not fully implemented in the confirmation flow.
In some cases the device could not be selected due to overly restrictive legacy path checks, and users were not guided through installing the multisig configuration required for manual verification.
This PR completes the Coldcard verification flow
CHANGES
TEST
Local Verification
npx turbo test --filter=@caravan/wallets
npx vitest run (apps/coordinator)
npx vitest run --coverage