feat(portal): support portal #2150
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
force-pushed
the
master
branch
3 times, most recently
from
234c1f9 to
e774974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to add portal support using Floating UI.
Why?
Currently, "popover" elements (dropdown menus, tooltips, modals etc..) are relative positioned, meaning that the element is contained within the component in the DOM. This causes z-index issues, where other elements may obstruct menus. Additionally, elements may be cut-off if an ancestor component manipulates
overflow: hidden.See issues tagged with "portal": https://github.com/carbon-design-system/carbon-components-svelte/issues?q=is%3Aissue%20state%3Aopen%20label%3Aportal
This is where a portal helps. It's a standard feature of UI, where "popover" elements are "portalled" outside of the root node for the main application. The portalled node is typically a sibling of the app node.
Proposed Changes
PortalandFloatingPortalcomponents.