Skip to content

Conversation

@annajiat
Copy link
Contributor

Current template forces to choose between address or online.
Added a comment to accommodate 'hybrid' for workshops being simultaneously held in-person and online

current template forces to choose between address or online.
added a comment to accommodate 'hybrid' for workshops being simultaneously held in-person and online
@netlify
Copy link

netlify bot commented Dec 12, 2022

Deploy Preview for workshop-template-previews ready!

Name Link
🔨 Latest commit 9b568cd
🔍 Latest deploy log https://app.netlify.com/sites/workshop-template-previews/deploys/6396d5e6a90ede0008195ee4
😎 Deploy Preview https://deploy-preview-778--workshop-template-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zkamvar
Copy link
Contributor

zkamvar commented Dec 12, 2022

Thank you for this PR @annajiat. There are a couple of things that need to happen before we merge this and make this a reality:

  1. The source code for the carpentries website needs to be modified to include a hybrid symbol (a la the online symbol as a globe that we currently have)
  2. hybrid needs to be included as a condition in
    {% if page.address == "online" %}
    and
    {% if page.address == "online" %}
    to display the information properly (note the latter is really a fix for styles)

Would you like me to take care of those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants