Carbonate Data Addition & Minor Updates#88
Open
EOGrady21 wants to merge 13 commits intocasaultb:masterfrom
Open
Carbonate Data Addition & Minor Updates#88EOGrady21 wants to merge 13 commits intocasaultb:masterfrom
EOGrady21 wants to merge 13 commits intocasaultb:masterfrom
Conversation
migrate from travis ci to github actions update version of pkgdown cache to resolve build error
per r cmd check note
Merge branch 'master' of https://github.com/EOGrady21/azmpdata # Conflicts: # vignettes/plotting_azmpdata.Rmd # vignettes/search_azmpdata.Rmd
Contributor
Author
|
Requesting review from @clayton33 and @casaultb before merging :) |
Contributor
|
I didn't do a detailed check, but your changes look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes the addition of derived carbonate chemistry data
It also includes minor updates to resolve testing errors, vignette building errors and r cmd check errors.
CI was migrated to github actions and all tests are passing!