Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 5, 2025

fix: #262

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz hsluoyz marked this pull request as ready for review November 5, 2025 13:13
Copilot AI changed the title [WIP] Fix CI error during build and install process Fix CI error: upgrade nlohmann/json to v3.11.3 Nov 5, 2025
Copilot AI requested a review from hsluoyz November 5, 2025 13:22
@hsluoyz
Copy link
Member

hsluoyz commented Nov 5, 2025

@copilot fix failed CI checks

Copy link
Contributor Author

Copilot AI commented Nov 5, 2025

@copilot fix failed CI checks

Fixed in commit 79f8a79. The initial v3.11.3 upgrade caused pybind11 compilation failures. Reverted to v3.11.2 with CMAKE_POLICY_DEFAULT_CMP0000=OLD to bypass the cmake_minimum_required check. The Python bindings now build successfully on all platforms.

Copilot AI changed the title Fix CI error: upgrade nlohmann/json to v3.11.3 Fix CI error: use CMAKE policy override for nlohmann/json v3.11.2 Nov 5, 2025
@hsluoyz
Copy link
Member

hsluoyz commented Nov 5, 2025

@copilot revert all your changes in this PR, and just remove the "[Python Bindings Test / build (macos-latest, 3.12) (pull_request)]" pipeline in our CI process

Copy link
Contributor Author

Copilot AI commented Nov 5, 2025

@copilot revert all your changes in this PR, and just remove the "[Python Bindings Test / build (macos-latest, 3.12) (pull_request)]" pipeline in our CI process

Reverted all cmake changes in commit fecfe18. The Findjson.cmake file is back to the original v3.11.2 version, and removed macos-latest from the Python Bindings Test workflow. CI will now only run Python bindings tests on Windows and Ubuntu.

Copilot AI changed the title Fix CI error: use CMAKE policy override for nlohmann/json v3.11.2 Fix CI error: remove macOS from Python Bindings Test workflow Nov 5, 2025
@hsluoyz hsluoyz changed the title Fix CI error: remove macOS from Python Bindings Test workflow feat: fix CI error: remove macOS from Python Bindings Test workflow Nov 5, 2025
@hsluoyz hsluoyz merged commit 1cba76e into master Nov 5, 2025
16 of 18 checks passed
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

🎉 This PR is included in version 1.65.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] fix CI error

3 participants