Restrict eval() to standard Casbin expressions for cross-platform compatibility #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eval() function was directly executing aviatorscript, allowing platform-specific syntax (
seq.list(),string.startsWith(),math.abs()) that breaks portability across Casbin implementations and exposes operations beyond specification.Changes
Core Validation
ExpressionEvaluatorwith regex-based validation blocking aviatorscript-specific featuresSEQ.list,String.StartsWith)EvalFunc.call()with sanitized error loggingAllowed Operations
r.sub.age,r.obj.owner==,&&,||,>,<,+,-,*,/keyMatch(),regexMatch(), custom functionsBlocked Operations
seq.*,string.*,math.*fn,lambda,let,for,whilenew,importMigration Example
Testing
EvalCrossPlatformTestvalidates exact issue scenariosDocumentation
Added
docs/ExpressionEvaluator.mdcovering allowed syntax, security improvements, and migration patterns.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.