Prevent wildcard deletion in deleteUser/deleteRole methods #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty string parameters in
deleteUser(),deleteRole(), and related methods act as wildcards inremoveFilteredPolicy, causing all policies to be deleted instead of filtering by the specified user/role. This results in destructive SQL queries likeDELETE FROM casbin_rule WHERE ptype = 'p'.Changes
deleteUser(),deleteRole(),deletePermission()deleteRoleForUser(),deleteRolesForUser(),deletePermissionsForUser(),deletePermissionForUser()undefined, andnullare rejectedExample
The fix catches empty strings,
undefined, andnullat the API boundary before they reach the filtering logic.Original prompt
casbin_ruletable #462💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.