Open
Conversation
Explicitly override the Quasar-bridged hyphenated variables so settings window background and native menu highlight color resolve correctly regardless of cascade order. Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
The main menu is rendered as a native OS menu via NativeContextMenu.spawn() and cannot be fully themed via CSS. Documents the highlight color workaround via Cider's custom accent color setting. Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
There was a problem hiding this comment.
Pull request overview
Updates the Catppuccin Cider themes to remain compatible with Cider 3.x/4.x by adding new palette variables and styling newly introduced/changed UI components.
Changes:
- Add missing Catppuccin palette variables (
--surface1,--surface2) and additional Cider/Quasar-related CSS variables (e.g.,--qDark*,--q-dark*,--mats-*). - Add/adjust styling for Cider v4-specific components (Concerts, LCD players, Solarium, various badges/popups).
- Update README guidance for setting the main menu accent color via Cider’s Custom Accent Color setting.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| themes/ctp-mocha/catppuccin-mocha.scss | Adds new CSS vars and extensive v4 component styling for Mocha. |
| themes/ctp-macchiato/catppuccin-macchiato.scss | Same as above for Macchiato. |
| themes/ctp-latte/catppuccin-latte.scss | Same as above for Latte (light flavor). |
| themes/ctp-frappe/catppuccin-frappe.scss | Same as above for Frappé. |
| templates/main.tera | Updates the generator template to emit the new vars and v4 styling. |
| README.md | Documents new limitation/workaround for main menu theming (accent color only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the theme to work with Cider 3.x and 4.x.
Closes #29