-
-
Notifications
You must be signed in to change notification settings - Fork 20
Use lifepillar/vim-colortemplate/ refact the repo #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
You're doing a lot of work in order to put catppuccin in the vim colorscheme repository, and i appreciate it.
|
provide mocha when background=dark and latte when it's light. and if you change 'background' it can change automatically.
The present implement use vim lagacy function, it is a bit slow. And I hope to use it in 256color environment. Furthermore, it can use one file to define all highlights and links. It is like what nvim's repo do now. So that if you want to have a change which should be added in all four themes, you only need to change once. |
The cost for calling the function for setting the colorgroups is negligible, and it already works with truecolors. Have you considered using our internal tool whiskers? |
Maybe I will try it in the future. It seems a bit complex. Time is late. I may try it tomorrow |
|
I've briefly reviewed the introduction of whiskers. Here are my thoughts: If I understand correctly, its operational model involves generating files by filling in blanks within configuration templates based on preset options. Its primary advantage over vim-colortemplate lies in the convenient fine-tuning of colors, such as {{ green | mod(opacity=0.3) | get(key="hex") }}. However, I believe vim-colortemplate is superior for the following reasons: Although I'm aware that Catppuccin is specifically designed for GUI true color, Vim, being a software with significant historical legacy, requires its plugins—including this project—to support 256 colors (disregarding 16-color support for now). This is because the colors automatically generated by Vim for GUI are not entirely accurate. There's no need to account for logic based on options like 'background', etc., which would lead to redundant workload. The current vim-colortemplate is much simpler in this regard. The primary reason is that Vim's color configuration files differ from standard formats like JSON or YAML, leaning more towards being a programming language where all the switching logic is pre-written internally. |
|
Since you're already creating a "legacy" port in the vim colorscheme repository, maybe we can use this repository as a "modern" version. So in the future if more plugins will be added, we can use the same approach for every part of the colorscheme, without having a part done in vim-colortemplate and others in whiskers |
|
Well, my main point is that I believe we could maintain a file that automatically switches based on the value of background. Whiskers' setup seems better suited for maintaining a single-color scheme file — though it's also possible that I haven't fully grasped how Whiskers works yet. |
Update with latest nvim's repo. Add support for 265 16 and 8 colors. These files are color templates for each palette, used to generate color scheme files in colors/*.vim. Use lifepillar/vim-colortemplate to build colorschemes from templates. Files descriptions: * _base -- Highlight group settings and links for Vim's internal settings. * _extra -- Highlight group settings and links for plugin support. * _frappe -- Frappe palette. * _latte -- Latte palette. * _macchiato -- Macchiato palette. * _mocha -- Mocha palette. * catppuccin.colortemplate -- Colortemplate for both light and dark backgrounds. * catppuccin_frappe.colortemplate -- Colortemplate for Frappe (one palette). * catppuccin_latte.colortemplate -- Colortemplate for Latte (one palette). * catppuccin_macchiato.colortemplate -- Colortemplate for Macchiato (one palette). * catppuccin_mocha.colortemplate -- Colortemplate for Mocha (one palette). Signed-off-by: Mao-Yining <[email protected]>
Update with latest nvim's repo.
make some changes. waiting for catppuccin/nvim#940