Fix RelyingParty#origin returning always nil
#484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquintomas2003
approved these changes
Oct 13, 2025
| # DEPRECATED: This method will be removed in future. | ||
| def origin | ||
| warn( | ||
| "DEPRECATION WARNING: `WebAuthn.origin` is deprecated and will be removed in future. "\ |
There was a problem hiding this comment.
Should this say WebAuthn.configuration.origin instead? 🤔
There was a problem hiding this comment.
That's a good call! I actually made it so that it display message as the one we currently have.
Either way, this is confusing because the method is in RelyingParty, not in WebAuth::Configuration... perhaps we could make it so that it throws a different validation depending if you are calling RelyingParty#origin or WebAuth::Configuration#origin, but I'd leave it for a separate PR.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #481.
This PR updates the
RelyingParty#origin(and thusWebAuthn.configuration.origin) so that, when there's only one allowed origin, it returns it while throwing a deprecation warning.