Add totalDifficulty field to JSON-RPC schema of Celo1 block #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piersy
reviewed
Jan 16, 2025
palango
reviewed
Jan 20, 2025
Kourin1996
deleted the
Kourin1996/add-totalDifficulty-in-RPC-block-for-celo1
branch
karlb
pushed a commit
that referenced
this pull request
Jan 27, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Feb 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 8, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 9, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 9, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 9, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 9, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 11, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 21, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 21, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 21, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 21, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 21, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 23, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
piersy
added a commit
that referenced
this pull request
Apr 24, 2025
* Add totalDifficulty field to JSON-RPC response for Celo1 header & block * Fix test * Remove new line --------- Co-authored-by: piersy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/celo-org/celo-blockchain-planning/issues/849
This PR adds the
totalDifficultyfield to the JSON-RPC response for Celo1 blocks.The
totalDifficultyis no longer present ingethandop-geth, as described in the following references:However, Celo2 requires RPC compatibility support for Celo1 blocks. Therefore, this PR adds
totalDifficultyfield specifically for Celo1 blocks.During my investigation, I discovered that snap sync does not store total difficulty into local database. As a result, the
totalDifficultyvalue in the RPC response is derived from the block height