Proposed fix for jam values in table based files #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandees
approved these changes
Jan 31, 2024
Member
iandees
left a comment
iandees
left a comment
There was a problem hiding this comment.
I might suggest putting it into the 03_import scripts instead, but this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a chunk of script at the bottom of the two table-based downloader files to strip out the specified "jam values" from data files, so that we don't inadvertently load spurious values next time we run these processes.
I've tested the code separate from actually loading the files into Postgres, but I figured it deserved more eyes, so submitting as a PR for @iandees review.