Skip to content

fix: Build Last Change #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: Build Last Change #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c88386c
fix: Rebuild
stanleyzapata Jan 22, 2025
e8aba5b
Commit from GitHub Actions (CI)
github-actions[bot] Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions force-app/lwc/signals/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ const UNSET = Symbol("UNSET");
const COMPUTING = Symbol("COMPUTING");
const ERRORED = Symbol("ERRORED");
const READY = Symbol("READY");
// The maximum stack depth value is derived from Salesforce's maximum stack depth limit in triggers.
// This value is chosen to prevent infinite loops while still allowing for a reasonable level of recursion.
const MAX_STACK_DEPTH = 16;
const defaultEffectOptions = {
_fromComputed: false,
identifier: Symbol()
Expand Down Expand Up @@ -38,15 +41,22 @@ function $effect(fn, options) {
const _optionsWithDefaults = { ...defaultEffectOptions, ...options };
const effectNode = {
error: null,
state: UNSET
state: UNSET,
stackDepth: 0
};
const execute = () => {
if (effectNode.state === COMPUTING) {
throw new Error("Circular dependency detected");
if (
effectNode.state === COMPUTING &&
effectNode.stackDepth >= MAX_STACK_DEPTH
) {
throw new Error(
`Circular dependency detected. Maximum stack depth of ${MAX_STACK_DEPTH} exceeded.`
);
}
context.push(execute);
try {
effectNode.state = COMPUTING;
effectNode.stackDepth++;
fn();
effectNode.error = null;
effectNode.state = READY;
Expand All @@ -58,6 +68,9 @@ function $effect(fn, options) {
: handleEffectError(error, _optionsWithDefaults);
} finally {
context.pop();
if (effectNode.stackDepth > 0) {
effectNode.stackDepth--;
}
}
};
execute();
Expand Down